Putting GHEs downstream of the buildings #677
Merged
+71
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
reviewed
Nov 21, 2024
| @@ -3,7 +3,8 @@ within {{ project_name }}.Loads.{{ model_name }}; | |||
| "Model of a building with an internal ETS. Building loads provided as time series" | |||
| extends Buildings.DHC.Loads.Combined.BaseClasses.PartialBuildingWithETS( | |||
| final allowFlowReversalSer=true, | |||
| {% endraw %}redeclare {{ project_name }}.Loads.{{ model_name }}.TimeSeriesBuilding bui( | |||
| {% endraw %}COPHeaWat_nominal={{data['cop_heating']}}, | |||
There was a problem hiding this comment.
Does this COPHeaWat_nominal get used in this model, or another model? Was it being automatically set and now we're explicitly setting it, and the usage is already written?
There was a problem hiding this comment.
It gets used in every model with a 5G ETS model. We were using the MBL default values before and now we take the user-defined value from the sys_params file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
This PR changes the couplings to put GHEs downstream of the buildings in the same building group.
Before:
After:
What does this PR accomplish?
It also changes the time series building template to take heat pump heating COP from the sys_params file.
How should this be manually tested?
poetry run any tests with GHEs and buildings.
What are the relevant tickets?
Issue #675 and issue #666.
Screenshots (if appropriate)